Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ux parse upload #972

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Improve ux parse upload #972

merged 2 commits into from
Jan 17, 2024

Conversation

cosa65
Copy link
Member

@cosa65 cosa65 commented Jan 16, 2024 •
edited
Loading

Description

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

biomage-org#70

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.
  • All new dependency licenses have been checked for compatibility.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@cosa65 cosa65 added the safe to run Sensitive jobs are safe to be run label Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/data-management 246.18 KB (🟡 +2.65 KB) 815.25 KB
/experiments/[experimentId]/data-exploration 519.96 KB (🟡 +48 B) 1.06 MB
/experiments/[experimentId]/data-processing 537.27 KB (🟡 +5 B) 1.08 MB
/repository 125.73 KB (🟡 +16.63 KB) 694.8 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (59da4ae) 85.07% compared to head (ca1eaf8) 85.11%.

Files Patch % Lines
src/utils/upload/fileUploadUtils.js 92.15% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
+ Coverage   85.07%   85.11%   +0.04%     
==========================================
  Files         548      548              
  Lines       10056    10092      +36     
  Branches     2172     2177       +5     
==========================================
+ Hits         8555     8590      +35     
- Misses       1441     1442       +1     
  Partials       60       60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosa65 cosa65 merged commit 8bdf046 into hms-dbmi-cellenics:master Jan 17, 2024
25 of 26 checks passed
@cosa65 cosa65 deleted the improve-ux-parse-upload branch January 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivababukova ivababukova ivababukova approved these changes

Assignees
No one assigned
Labels
safe to run Sensitive jobs are safe to be run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosa65 @ivababukova